[Backport] Removed comma(,) from translate attribute#15615
Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom Jun 2, 2018
Merged
[Backport] Removed comma(,) from translate attribute#15615magento-engcom-team merged 2 commits intomagento:2.2-developfrom
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
Conversation
dmytro-ch
added
Release Line: 2.2
partners-contribution
rogyar
suggested changes
May 31, 2018
| </field> | ||
| </group> | ||
| <group id="dashboard" translate="label,comment" sortOrder="60" showInDefault="1" showInWebsite="0" showInStore="0"> | ||
| <group id="dashboard" translate="label comment" sortOrder="60" showInDefault="1" showInWebsite="0" showInStore="0"> |
Contributor
There was a problem hiding this comment.
I would recommend removing the comment completely. We don't have this section within a scope of the current node. The same is actual for "Orders Cron Settings" group as well
Contributor
There was a problem hiding this comment.
Also, it's a good idea to add comment value to the child 'field' node
4 tasks
Contributor
Author
|
Thank you @rogyar. This is a good point :) |
rogyar
approved these changes
Jun 1, 2018
magento-engcom-team
added
Component: Sales
Progress: accept
and removed
Progress: needs update
labels
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 2, 2018
Contributor
|
Hi @dmytro-ch. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#14363
There should be space instead of the comma(,) for separating two tag name inside the value of translate attribute.
Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A
Contribution checklist